[PECOBLR-421] Add explicit null check for empty values in an Arrow value vector#827
Merged
Conversation
| // The zero value should still be correctly identified as 0, not null | ||
| assertFalse(vector.isNull(2)); | ||
| assertEquals((byte) 0, convert(vector, 2, ColumnInfoTypeName.BYTE, "BYTE")); | ||
| } |
Collaborator
There was a problem hiding this comment.
These tests are not actually testing any change in behaviour in our class, can we instead do verify calls to ensure the appropriate methods are being called when the value vector is null?
Collaborator
Author
There was a problem hiding this comment.
This is still not simulating iceberg library usage. Need to find a better test case for that. Will handle in separate PR.
Collaborator
|
In the description, can you add the stack trace faced by the customer? And how did we verify that this fix is working ? |
vikrantpuppala
approved these changes
May 15, 2025
Collaborator
Author
Verified by adding test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added explicit null check for empty value in an Arrow value vector. This issue comes when Arrow null check is disabled for optimized performance.
Testing
Added unit tests
Additional Notes to the Reviewer